This repository has been archived by the owner on Apr 6, 2023. It is now read-only.
fix(nuxt): use suspense for child pages on client-side navigation #4677
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
resolves nuxt/nuxt#13797
β Type of change
π Description
Context: #4422.
This PR amends that behaviour. Initial load still includes children in the parent's suspense, but further navigation wraps child pages in suspense (which is required if not reloading the parent on further nav).
Note:
isHydrating
is not reactive so it doesn't trigger a rerender.π Checklist