Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

feat(nitro): add nitro:build:before hook #4304

Merged
merged 9 commits into from
May 2, 2022
Merged

feat(nitro): add nitro:build:before hook #4304

merged 9 commits into from
May 2, 2022

Conversation

danielroe
Copy link
Member

🔗 Linked issue

resolves nuxt/nuxt#13701

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Adds back nitro:generate hook.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added bug Something isn't working nitro ❗ p4-important Priority 4: bugs that violate documented behavior, or significantly impact perf labels Apr 12, 2022
@danielroe danielroe requested a review from pi0 April 12, 2022 15:27
@danielroe danielroe self-assigned this Apr 12, 2022
@netlify
Copy link

netlify bot commented Apr 12, 2022 •
edited
Loading

✅ Deploy Preview for nuxt3-docs canceled.

Name Link
🔨 Latest commit 23898bf
🔍 Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/62703b7a4a4eb70008732602

@danielroe danielroe mentioned this pull request Apr 13, 2022
Closed
@benoitdemaegdt benoitdemaegdt mentioned this pull request Apr 14, 2022
Closed
@pi0
Copy link
Member

pi0 commented Apr 15, 2022

(PR is pending in order to deprecate nitro: hooks)

@pi0 pi0 self-assigned this Apr 15, 2022
@pi0 pi0 added the pending label Apr 15, 2022
@benoitdemaegdt
Copy link

It seems that partytown module was fixed without the need of this PR :
nuxt-modules/partytown@bf4cfca

Will this PR be merged ? Or the intent is to close it ?

@pi0 pi0 closed this Apr 19, 2022
@pi0 pi0 deleted the fix/nitro-generate-hook branch April 19, 2022 19:15
@danielroe danielroe mentioned this pull request Jan 19, 2023
Closed
@danielroe danielroe restored the fix/nitro-generate-hook branch May 1, 2022 07:59
@danielroe danielroe reopened this May 1, 2022
@pi0 pi0 changed the title fix(nitro): add back nitro:generate hook feat(nitro): add nitro:build:before hook May 2, 2022
@pi0 pi0 merged commit 1f8e3e2 into main May 2, 2022
@pi0 pi0 deleted the fix/nitro-generate-hook branch May 2, 2022 20:15
@pi0 pi0 mentioned this pull request May 2, 2022
Merged
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pi0 pi0 pi0 left review comments

Assignees

@pi0 pi0

@danielroe danielroe

Labels
3.x bug Something isn't working nitro ❗ p4-important Priority 4: bugs that violate documented behavior, or significantly impact perf pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add back nitro:generate hook
3 participants
@danielroe @pi0 @benoitdemaegdt