This repository has been archived by the owner on Apr 6, 2023. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
feat(nuxi): support mode flags for add
command
#3921
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
β Deploy Preview for nuxt3-docs canceled.
|
pi0
reviewed
Mar 28, 2022
Co-authored-by: pooya parsa <pyapar@gmail.com>
β¦nto feat/cli-mode-flags
Co-authored-by: pooya parsa <pyapar@gmail.com>
pi0
reviewed
Mar 28, 2022
atinux
reviewed
Mar 29, 2022
Co-authored-by: SΓ©bastien Chopin <seb@nuxtjs.com>
β¦nto feat/cli-mode-flags
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
pi0
approved these changes
Aug 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I've made a small refactor that enables modifiers for components, API, etc per template.
2288dc8
to
c2dca8a
Compare
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Description
Allow
--client|--server
flags to be used withnuxi add
to specify that the respective entity should be either client / server only.This PR also handles the case where a user manually specifies a file extension when using
nuxi add
, With current implementationnuxi add plugin test.ts
would result in/plugins/test.ts.ts
being generated.Side note: Nuxt 3 encourages typescript usage for optimal developer experience, hence though different entities allow for varying extensions,
nuxi add
defaults to (and enforces).vue
and.ts
.π Checklist