-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
fix(nuxt): support deep assign on empty object for app config #10087
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
π―
I have a small suggestion about We currently use The issue with that is that While this works very good, I think it would be amazing being able to send only partial updates to the app.config, without implying Also, I don't think deleting keys from the |
@Tahul Can you please open an issue with steps to reproduce? Indeed update shouldn't delete missing sub-keys too. BTW we initially did it because it was making strange behavior when a user removes an optional-option from main |
The What are the steps that brings a bad DX? |
Wow, my bad, sorry for not double-checking that. I thought the same sequence occurred in HMR and in runtime call. I was mentioning this lately while working on studio because we allow partial updates for tokens.config and I thought that same partial updates would break with You can consider this closed, sorry π |
π Linked issue
No linked issue, but a reproduction: https://stackblitz.com/edit/github-mgmeto?file=app.config.ts,app.vue
Tested locally in playground with my fix and works.
β Type of change