Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

Commit

Permalink
fix(nuxt): add viteServerDynamicImports as experimental flag (#6433)
Browse files Browse the repository at this point in the history
  • Loading branch information
pi0 committed Aug 8, 2022
1 parent 4ec68db commit ee36ddf
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 10 deletions.
9 changes: 9 additions & 0 deletions packages/schema/src/config/experimental.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,5 +30,14 @@ export default {
* @see https://github.com/nuxt/framework/pull/5750
*/
treeshakeClientOnly: false,

/**
* Split server bundle into multiple chunks and dynamically import them
*
* Note: Enabling this flag can cause hydration issues in some platform.
*
* @see https://github.com/nuxt/framework/issues/6432
*/
viteServerDynamicImports: false,
}
}
1 change: 0 additions & 1 deletion packages/vite/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@
"postcss-url": "^10.1.3",
"rollup": "^2.77.2",
"rollup-plugin-visualizer": "^5.7.1",
"std-env": "^3.1.1",
"ufo": "^0.8.5",
"unplugin": "^0.8.1",
"vite": "~3.0.4",
Expand Down
9 changes: 1 addition & 8 deletions packages/vite/src/server.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,9 @@ import { resolveTSConfig } from 'pkg-types'
import { resolve } from 'pathe'
import * as vite from 'vite'
import vuePlugin from '@vitejs/plugin-vue'
import { provider } from 'std-env'
import viteJsxPlugin from '@vitejs/plugin-vue-jsx'
import { logger, resolveModule } from '@nuxt/kit'
import { joinURL, withoutLeadingSlash, withTrailingSlash } from 'ufo'
import type { OutputOptions } from 'rollup'
import { ViteBuildContext, ViteOptions } from './vite'
import { wpfs } from './utils/wpfs'
import { cacheDirPlugin } from './plugins/cache-dir'
Expand Down Expand Up @@ -80,7 +78,7 @@ export async function buildServer (ctx: ViteBuildContext) {
entryFileNames: 'server.mjs',
preferConst: true,
// TODO: https://github.com/vitejs/vite/pull/8641
inlineDynamicImports: false,
inlineDynamicImports: !ctx.nuxt.options.experimental.viteServerDynamicImports,
format: 'module'
},
onwarn (warning, rollupWarn) {
Expand Down Expand Up @@ -112,11 +110,6 @@ export async function buildServer (ctx: ViteBuildContext) {
}))
}

// Hotfix for https://github.com/nuxt/framework/issues/6204
if (provider === 'netlify') {
(serverConfig.build.rollupOptions.output as OutputOptions).inlineDynamicImports = true
}

await ctx.nuxt.callHook('vite:extendConfig', serverConfig, { isClient: false, isServer: true })

const onBuild = () => ctx.nuxt.callHook('build:resources', wpfs)
Expand Down
1 change: 0 additions & 1 deletion yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -1886,7 +1886,6 @@ __metadata:
postcss-url: ^10.1.3
rollup: ^2.77.2
rollup-plugin-visualizer: ^5.7.1
std-env: ^3.1.1
ufo: ^0.8.5
unbuild: latest
unplugin: ^0.8.1
Expand Down

0 comments on commit ee36ddf

Please sign in to comment.