chore(deps): update devdependency @nuxtjs/eslint-config-typescript to…

… v12 (#9086) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Daniel Roe <daniel@roe.dev>
nuxt · Jan 14, 2023 · 0b1cdcc · 0b1cdcc
1 parent f314e9d
commit 0b1cdcc
Show file tree

Hide file tree

Showing 15 changed files with 107 additions and 95 deletions.
diff --git a/docs/scripts/gen-docs.ts b/docs/scripts/gen-docs.ts
@@ -116,6 +116,7 @@ async function generateDocs ({ configFile, configTemplate }) {
   const start = Date.now()
   console.log(`Updating docs on ${configFile}`)
   const template = await readFile(configTemplate, 'utf8')
+  // eslint-disable-next-line @typescript-eslint/no-var-requires
   const rootSchema = require('../../packages/schema/schema/config.schema.json') as Schema
   const keys = Object.keys(rootSchema.properties).sort()
   let generatedDocs = ''

diff --git a/docs/scripts/map-redirects.js b/docs/scripts/map-redirects.js
@@ -1,3 +1,4 @@
+// eslint-disable-next-line @typescript-eslint/no-var-requires
 const { readFile, writeFile } = require('node:fs/promises')
 
 const netlifyToVercel = (redirects) => {

diff --git a/examples/routing/layouts/middleware/other.ts b/examples/routing/layouts/middleware/other.ts
@@ -1,4 +1,4 @@
-// eslint-disable-next-line @typescript-eslint/no-unused-vars
+
 export default defineNuxtRouteMiddleware(() => {
   setPageLayout('other')
 })
diff --git a/package.json b/package.json
@@ -46,7 +46,7 @@
     "@nuxt/test-utils": "workspace:*",
     "@nuxt/vite-builder": "workspace:*",
     "@nuxt/webpack-builder": "workspace:*",
-    "@nuxtjs/eslint-config-typescript": "^11.0.0",
+    "@nuxtjs/eslint-config-typescript": "^12.0.0",
     "@types/crawler": "^1.2.2",
     "@types/node": "^18.11.18",
     "@types/rimraf": "^3",

diff --git a/packages/nuxt/src/app/components/nuxt-island.ts b/packages/nuxt/src/app/components/nuxt-island.ts
@@ -54,14 +54,14 @@ export default defineComponent({
       html.value = res.html
     }
 
-    if (process.server || !nuxtApp.isHydrating) {
-      await fetchComponent()
-    }
-
     if (process.client) {
       watch(props, debounce(fetchComponent, 100))
     }
 
+    if (process.server || !nuxtApp.isHydrating) {
+      await fetchComponent()
+    }
+
     return () => createStaticVNode(html.value, 1)
   }
 })
diff --git a/packages/nuxt/src/app/composables/ssr.ts b/packages/nuxt/src/app/composables/ssr.ts
@@ -1,4 +1,4 @@
-/* eslint-disable no-redeclare */
+
 import type { H3Event } from 'h3'
 import type { NuxtApp } from '../nuxt'
 import { useNuxtApp } from '../nuxt'

diff --git a/packages/nuxt/src/app/entry.ts b/packages/nuxt/src/app/entry.ts
@@ -77,7 +77,7 @@ if (process.client) {
   }
 
   entry().catch((error: unknown) => {
-    console.error('Error while mounting app:', error) // eslint-disable-line no-console
+    console.error('Error while mounting app:', error)
   })
 }
 

diff --git a/packages/nuxt/src/components/module.ts b/packages/nuxt/src/components/module.ts
@@ -81,7 +81,6 @@ export default defineNuxtModule<ComponentsOptions>({
 
         const present = isDirectory(dirPath)
         if (!present && !DEFAULT_COMPONENTS_DIRS_RE.test(dirOptions.path)) {
-          // eslint-disable-next-line no-console
           console.warn('Components directory not found: `' + dirPath + '`')
         }
 

diff --git a/packages/nuxt/src/components/scan.ts b/packages/nuxt/src/components/scan.ts
@@ -3,6 +3,7 @@ import { globby } from 'globby'
 import { pascalCase, splitByCase } from 'scule'
 import type { Component, ComponentsDir } from '@nuxt/schema'
 import { isIgnored } from '@nuxt/kit'
+// eslint-disable-next-line vue/prefer-import-from-vue
 import { hyphenate } from '@vue/shared'
 import { withTrailingSlash } from 'ufo'
 

diff --git a/packages/nuxt/src/pages/utils.ts b/packages/nuxt/src/pages/utils.ts
@@ -181,7 +181,7 @@ function parseSegment (segment: string) {
         } else if (PARAM_CHAR_RE.test(c)) {
           buffer += c
         } else {
-          // eslint-disable-next-line no-console
+
           // console.debug(`[pages]Ignored character "${c}" while building param "${buffer}" from "segment"`)
         }
         break

diff --git a/packages/vite/src/dev-bundler.ts b/packages/vite/src/dev-bundler.ts
@@ -78,7 +78,6 @@ ${genDynamicImport(path, { wrapper: false })}
 
   // Transform
   const res: SSRTransformResult = await opts.viteServer.transformRequest(id, { ssr: true }).catch((err) => {
-    // eslint-disable-next-line no-console
     console.warn(`[SSR] Error transforming ${id}:`, err)
     // console.error(err)
   }) as SSRTransformResult || { code: '', map: {}, deps: [], dynamicDeps: [] }

diff --git a/packages/webpack/src/plugins/vue/client.ts b/packages/webpack/src/plugins/vue/client.ts
@@ -109,7 +109,7 @@ export default class VueSSRClientPlugin {
           // Find all asset modules associated with the same chunk
           assetModules.forEach((m) => {
             if (m.chunks!.includes(cid)) {
-              files.push.apply(files, (m.assets as string[]).map(fileToIndex))
+              files.push(...(m.assets as string[]).map(fileToIndex))
             }
           })
         }