SQL: Fix locking with MS SQL Server #3394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reinkrul
requested review from
woutslakhorst and
gerardsn
and removed request for
woutslakhorst
woutslakhorst
requested changes
Sep 20, 2024
I did that in the RFC021 e2e-test as part of #3391 by enabling revocation status for the issued credentials. Although I don't necessarily think that's the right test (because it was originally intended to be RFC021-specific), having a varying set of databases tested in different tests here and there, is not very maintainable. As RFC021 is actually the "only" use case/flow we truly support and use for v6, maybe we can keep all variants we need (MySql/Postgres/MSSQL Server) there? |
woutslakhorst
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3393