Add many2many relationship for DID document services and verification methods #3373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woutslakhorst
approved these changes
Sep 16, 2024
gerardsn
deleted the
fix-3367/add-many2many-relationship-for-services-and-vms
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3367
The relationships are currently one way: did document -> service / vm. I don't think we need the other direction anytime soon.
Renamed
DIDDocumenttoDidDocumentso gorm parses it asdid_document(and notd_id_document). This can be handled with tags, so I can revert this if needed.Also changed table
did_verificationmethodtodid_verification_methodfor the same reason, but these are 2 words so imo should be separated with a_