Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v5.4: fix error message in private key existence check #3305

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

gerardsn
Copy link
Member

@gerardsn gerardsn commented Aug 9, 2024

aligned the message with v6.
In V6 Exists also returns an error clarifying this even further.

@stevenvegt
Copy link
Member

I would suggest changing the interface to return the error instead. Helps us to debug in the future. Perhaps the vault service is down or some other thing has happened.

@gerardsn
Copy link
Member Author

gerardsn commented Aug 9, 2024

That would have to be a new issue that will eventually end up on the wontfix pile as this is already fixed in v6. I was just going for a message that is less deterministic about the cause of the failure.

Copy link
Member

@stevenvegt stevenvegt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is rewritten in v6, this should do the job for the remainder of the lifetime of the v5 branch.

@gerardsn gerardsn merged commit b4c9499 into V5.4 Aug 9, 2024
4 checks passed
@gerardsn gerardsn deleted the fix-private-key-error-msg-v5.4 branch August 9, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants