Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IAM: fix loading of server state #3011

Merged
merged 3 commits into from
Apr 5, 2024
Merged

IAM: fix loading of server state #3011

merged 3 commits into from
Apr 5, 2024

Conversation

reinkrul
Copy link
Member

@reinkrul reinkrul commented Apr 3, 2024

After loading the session from the store, the fields became typed as []interface{} and map[string]interface{}, making them uncastable.

Should we consider making ServerState a struct instead of a map, instead?

@reinkrul reinkrul requested review from woutslakhorst and gerardsn and removed request for woutslakhorst April 3, 2024 05:17
@woutslakhorst
Copy link
Member

Should we consider making ServerState a struct instead of a map, instead?

We know of all the data that's being stored in the ServerState, there's no runtime magic. So let's make it a struct and just use normal marshalling/unmarshalling.

@reinkrul
Copy link
Member Author

reinkrul commented Apr 3, 2024

Should we consider making ServerState a struct instead of a map, instead?

We know of all the data that's being stored in the ServerState, there's no runtime magic. So let's make it a struct and just use normal marshalling/unmarshalling.

Fixed

@reinkrul reinkrul merged commit 2d9db64 into master Apr 5, 2024
9 checks passed
@reinkrul reinkrul deleted the iam/serverstate-loading branch April 5, 2024 07:17
rolandgroen added a commit that referenced this pull request Apr 8, 2024
* master: (21 commits)
  IAM: Remove OpenID4VP PoC code (#3022)
  Bump golang.org/x/crypto from 0.21.0 to 0.22.0 (#3021)
  VDR: Support root did:web DIDs (#2900)
  extended policy mapping for user/organization (#2977)
  IAM: fix loading of server state (#3011)
  Bump github.com/nats-io/nats.go from 1.34.0 to 1.34.1 (#3018)
  Bump github.com/prometheus/client_model from 0.6.0 to 0.6.1 (#3017)
  Bump google.golang.org/grpc from 1.62.1 to 1.63.0 (#3016)
  Update golang.org/x/net@v0.23.0 (#3014)
  Ignore allowUntrustedIssuer for did:web and clarify 'revocation' in vcr/search (#2992)
  document liveness and readiness probes (#2982)
  IAM: Allow user details to be passed in requestUserAccessToken (#2990)
  Policy: allow multiple policy files in local PDP (#3010)
  Bump github.com/amacneil/dbmate/v2 from 2.13.0 to 2.14.0 (#2999)
  Docker: don't run as root user (#2917)
  Add missing copyright notices (#3000)
  Set SQL logging to TRACE instead of DEBUG (#3002)
  fix invalid swagger (#2988)
  add credentialStatus to common ssi_types (#2989)
  Auth: IAM client should not use PKI TLS config (#2998)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants