always write index data for VDR, never check on duplicate #2141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woutslakhorst
force-pushed
the
fix/2140_always_write_vdr
branch
from
ca9dc7e
to
f2ea853
Compare
gerardsn
reviewed
May 12, 2023
| @@ -75,35 +75,35 @@ func (tl *store) Configure(_ core.ServerConfig) (err error) { | |||
| // Add inserts the document version at the correct place and updates all later versions if needed | |||
| // The integrity of the document has already been checked by the DAG. | |||
| func (tl *store) Add(didDocument did.Document, transaction Transaction) error { | |||
| // prevents parallel execution | |||
| err := tl.db.Write(context.Background(), func(tx stoabs.WriteTx) error { | |||
There was a problem hiding this comment.
Why is this split in 2 write operations?
vdr/didstore/store.go
Outdated
| } | ||
| if err = applyFrom(tx, base, applyList); err != nil { | ||
| return fmt.Errorf("applying event list failed: %w", err) | ||
| } | ||
| } | ||
| return writeEventList(tx, currentEventList, didDocument.ID) |
There was a problem hiding this comment.
why is it writing the eventList if it has not been changed?
My feedback would be the same. Adding some lengthy comments about why we are doing these inserts etc., what we're trying to work around, etc. would be good. |
gerardsn
approved these changes
May 15, 2023
woutslakhorst
added a commit
that referenced
this pull request
May 15, 2023
woutslakhorst
added a commit
that referenced
this pull request
May 15, 2023
woutslakhorst
added a commit
that referenced
this pull request
May 16, 2023
woutslakhorst
added a commit
that referenced
this pull request
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2140
One of the problems is that a TX ref is missing in the VDR, but it's content is applied. Now the doc can't get updated anymore. Always writing the TX ref first will resolve that problem. Other problems may still exist....
Backport to master and other V5 versions.
It has been tested by a vendor, seems to resolve the issue of a broken VDR!