Auth: do not escape parameters in rendered IRMA contracts #1936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenvegt
reviewed
Mar 1, 2023
stevenvegt
requested changes
Mar 1, 2023
|
Tests are failing because the e2e tests now include external crypto storage, but the V5 branch doesn't. |
stevenvegt
approved these changes
Mar 1, 2023
|
I tested it with the IRMA app, using the current v5.0.9 version the IRMA app shows the contract text with |
|
manual run of e2e tests is successful |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1931
Also apply on master.