Skip to content
This repository has been archived by the owner on Jun 10, 2020. It is now read-only.

Bumpy mypy versions #28

Merged
merged 6 commits into from
Nov 21, 2018
Merged

Bumpy mypy versions #28

merged 6 commits into from
Nov 21, 2018

Conversation

alanhdu
Copy link
Contributor

@alanhdu alanhdu commented Nov 20, 2018

Bumping the mypy version required re-ordering some of the overload.

Bumping the flake8 version created new errors, so I used https://github.com/ambv/black to autoformat the *.pyi stub files. (This is also helpful because it's what i used for the autogenerated stubs for #11). Is this the right approach, or should we just manually format these stub files?

.travis.yml Outdated
python: 3.6
python:
- 3.6
- 3.7
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you may need to copy a few lines from NumPy's .travis.yml to check Python 3.7 working:
https://github.com/numpy/numpy/blob/4f1541e1cb68beb3049a21cbdec6e3d30c2afbbb/.travis.yml#L39-L41

@shoyer
Copy link
Member

shoyer commented Nov 21, 2018

I do like the look of black formatted code here. It's not what we normally do for NumPy but I don't see any harm in trying it here. @sproshev any thoughts?

@max-sixty
Copy link

I do like the look of black formatted code here. It's not what we normally do for NumPy but I don't see any harm in trying it here

FYI we've used it in pandas-gbq, it's been great for not worrying about formatting. We've also rolled it out to our smaller / newer internal repos. Would be a mammoth diff for a project like xarray though

@shoyer shoyer merged commit 57eedfd into numpy:master Nov 21, 2018
@shoyer
Copy link
Member

shoyer commented Nov 21, 2018

Thanks!

@alanhdu alanhdu deleted the version-bump branch November 22, 2018 20:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants