Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GET /items to match with API documentation #176

Open
wants to merge 1 commit into
base: backend
Choose a base branch
from

Conversation

Lai-YT
Copy link
Collaborator

@Lai-YT Lai-YT commented Jan 12, 2023

What's changed?

GET /items 在實作時沒有符合 API 文件的定義,遺漏了 count 這個欄位。
此 PR 修復了上述問題,使實際介面和文件保持一致。

@Lai-YT Lai-YT added bug Something isn't working backend labels Jan 12, 2023
@Lai-YT Lai-YT requested a review from ntut-xuan January 12, 2023 15:36
@Lai-YT Lai-YT self-assigned this Jan 12, 2023
@codecov
Copy link

codecov bot commented Jan 12, 2023

Codecov Report

Merging #176 (02a0107) into backend (711320e) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           backend     #176   +/-   ##
========================================
  Coverage    99.89%   99.89%           
========================================
  Files           21       21           
  Lines          967      967           
  Branches        89       89           
========================================
  Hits           966      966           
  Partials         1        1           
Impacted Files Coverage Δ
backend/src/item/route.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant