fix(core): import handles argument escaping correctly in Windows #27957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit a99d5ea. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targets
Sent with 💌 from NxCloud. |
jaysoo
added
the
PR status: do not merge
🐳 We have a release for that!This PR has a release associated with it. You can try it out using this command: npx create-nx-workspace@0.0.0-pr-27957-7e3588c my-workspaceOr just copy this version and use it in your own command: 0.0.0-pr-27957-7e3588c
To request a new release for this pull request, mention someone from the Nx team or the |
jaysoo
force-pushed
the
fix/import-history-windows
branch
from
7e3588c
to
1044b72
Compare
jaysoo
force-pushed
the
fix/import-history-windows
branch
from
1044b72
to
a99d5ea
Compare
jaysoo
removed
the
PR status: do not merge
🐳 We have a release for that!This PR has a release associated with it. You can try it out using this command: npx create-nx-workspace@0.0.0-pr-27957-a99d5ea my-workspaceOr just copy this version and use it in your own command: 0.0.0-pr-27957-a99d5ea
To request a new release for this pull request, mention someone from the Nx team or the |
FrozenPandaz
approved these changes
Sep 17, 2024
FrozenPandaz
pushed a commit
that referenced
this pull request
Sep 18, 2024
) This PR handles Windows arguments correctly, since Powershell and Cmd do not support single quotes. **Changes:** - Properly escape '\' in Windows paths - Set source and destination using environment variables rather than args to avoid pwsh handling of quotes (cherry picked from commit 91e3ac0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR handles Windows arguments correctly, since Powershell and Cmd do not support single quotes.
Changes: