fix(nx-cloud): include nxCloudId when generating connect urls #27882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 305f02d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targets
Sent with 💌 from NxCloud. |
lourw
force-pushed
the
lourw/update-create-workspace
branch
from
dd61c5b
to
501ddac
Compare
lourw
requested review from
a team,
FrozenPandaz,
vsavkin,
AgentEnder,
jaysoo and
JamesHenry
as code owners
lourw
force-pushed
the
lourw/update-create-workspace
branch
from
501ddac
to
0cd20ea
Compare
lourw
commented
Sep 12, 2024
| const response = await require('axios').post( | ||
| `${apiUrl}/nx-cloud/is-workspace-claimed`, | ||
| { |
There was a problem hiding this comment.
API for this endpoint had changed since it was written. You need to specify the type of token being passed to the API
lourw
force-pushed
the
lourw/update-create-workspace
branch
2 times, most recently
from
1f095d0
to
c6fbbd0
Compare
FrozenPandaz
approved these changes
Sep 12, 2024
|
|
||
| const apiUrl = getCloudUrl(); | ||
| try { | ||
| const requestData = isNxCloudId(accessToken) |
There was a problem hiding this comment.
We should be able to tell when invoking this function whether or not it is an ID or an access token based on where we read it/created it from.
Let's address this separately.
ndcunningham
approved these changes
Sep 12, 2024
lourw
force-pushed
the
lourw/update-create-workspace
branch
from
c6fbbd0
to
305f02d
Compare
FrozenPandaz
pushed a commit
that referenced
this pull request
Sep 12, 2024
<!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior <!-- This is the behavior we have today --> ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> NxCloudId should be part of the URL that is created when connecting a new workspace. ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes # (cherry picked from commit 7f7e4d0)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Expected Behavior
NxCloudId should be part of the URL that is created when connecting a new workspace.
Related Issue(s)
Fixes #