Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(expo): add cacheVersion to metro.config #27646

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

xiongemi
Copy link
Collaborator

@xiongemi xiongemi commented Aug 27, 2024

Current Behavior

expo tends to cache the output if there is no change in metro.config.js
we don't need to explicitly set the args --clear when expo/expo#30930 is fixed

Expected Behavior

Related Issue(s)

Fixes #27392

@xiongemi xiongemi requested a review from a team as a code owner August 27, 2024 06:33
@xiongemi xiongemi requested a review from jaysoo August 27, 2024 06:33
Copy link

vercel bot commented Aug 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Aug 28, 2024 7:24pm

@xiongemi xiongemi force-pushed the fix/fix-clear-expo-cache-export branch from 43902cd to dde1a64 Compare August 28, 2024 17:41
@xiongemi xiongemi changed the title fix(expo): clear cache for expo export fix(expo): add cacheVersion to metro.config Aug 28, 2024
@xiongemi xiongemi force-pushed the fix/fix-clear-expo-cache-export branch 2 times, most recently from 59bea7c to 98e18e4 Compare August 28, 2024 18:12
@xiongemi xiongemi force-pushed the fix/fix-clear-expo-cache-export branch from 98e18e4 to 61f36cc Compare August 28, 2024 19:21
@xiongemi xiongemi merged commit 925672e into master Aug 29, 2024
6 checks passed
@xiongemi xiongemi deleted the fix/fix-clear-expo-cache-export branch August 29, 2024 19:36
FrozenPandaz pushed a commit that referenced this pull request Sep 3, 2024
<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

## Current Behavior
<!-- This is the behavior we have today -->
expo tends to cache the output if there is no change in metro.config.js
we don't need to explicitly set the args --clear when
expo/expo#30930 is fixed

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #27392

(cherry picked from commit 925672e)
Copy link

github-actions bot commented Sep 4, 2024

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

metro web builds cache key collision
3 participants