fix(core): nx migrate should determine angular devkit migration from cli or schematics #20282 #27634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
…cli or schematics #20282
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 90f534b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targets
Sent with 💌 from NxCloud. |
Coly010
force-pushed
the
angular/migrate-schematics
branch
from
f49154c
to
90f534b
Compare
FrozenPandaz
approved these changes
Aug 26, 2024
leosvelperez
approved these changes
Aug 26, 2024
FrozenPandaz
pushed a commit
that referenced
this pull request
Aug 26, 2024
…cli or schematics #20282 (#27634) <!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior <!-- This is the behavior we have today --> We check the CLI property exists and if it's not `nx` we will use the ng compat layer to run the migration. If the CLI property does not exist, we check both if the migration is in the `schematics` object on the `migrations.json` and if the contents of the migration implementation contains an import from `@angular-devkit`. The problem with the fallback is that if only types are imported from `@angular-devkit` the import is stripped from the migration implementation completely. ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> We had planned already to remove the fallback of reading the file contents. We had also planned to remove using the `cli` property to determine if the migration needed the `ng compat layer`. However, as the `cli` property is still useful for now for package's that needed some manner to circumvent the flawed fallback logic, let's continue to use it until v21. Log a warning however if the `cli !== 'nx'` and it is placed in the `generators` section of the `migrations.json` to provide ample time for plugin developers to move them to the `schematics` property. Fallback has been updated to whether or not the migration lives in `schematics` and not flawed read file logic. ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #20282 (cherry picked from commit 62c6512)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
We check the CLI property exists and if it's not
nxwe will use the ng compat layer to run the migration.If the CLI property does not exist, we check both if the migration is in the
schematicsobject on themigrations.jsonand if the contents of the migration implementation contains an import from@angular-devkit.The problem with the fallback is that if only types are imported from
@angular-devkitthe import is stripped from the migration implementation completely.Expected Behavior
We had planned already to remove the fallback of reading the file contents.
We had also planned to remove using the
cliproperty to determine if the migration needed theng compat layer.However, as the
cliproperty is still useful for now for package's that needed some manner to circumvent the flawed fallback logic, let's continue to use it until v21.Log a warning however if the
cli !== 'nx'and it is placed in thegeneratorssection of themigrations.jsonto provide ample time for plugin developers to move them to theschematicsproperty.Fallback has been updated to whether or not the migration lives in
schematicsand not flawed read file logic.Related Issue(s)
Fixes #20282