Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bundling): add option to generate sourcemaps for Rollup build #27539

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Aug 20, 2024

This PR adds sourceMap option to @nx/rollup:rollup executor and the withNx util (for Project Crystal). The same option is used for Webpack.

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #9119

@jaysoo jaysoo requested a review from a team as a code owner August 20, 2024 13:43
Copy link

vercel bot commented Aug 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Aug 20, 2024 2:06pm

@jaysoo jaysoo requested a review from a team as a code owner August 20, 2024 13:57
@jaysoo jaysoo enabled auto-merge (squash) August 20, 2024 14:15
@jaysoo jaysoo merged commit fdb488b into master Aug 20, 2024
6 checks passed
@jaysoo jaysoo deleted the issue/9119 branch August 20, 2024 14:28
AgentEnder pushed a commit to imnasnainaec/nx that referenced this pull request Aug 20, 2024
…rwl#27539)

This PR adds `sourceMap` option to `@nx/rollup:rollup` executor and the
`withNx` util (for Project Crystal). The same option is used for
Webpack.

## Current Behavior
<!-- This is the behavior we have today -->

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes nrwl#9199
FrozenPandaz pushed a commit that referenced this pull request Aug 21, 2024
…27539)

This PR adds `sourceMap` option to `@nx/rollup:rollup` executor and the
`withNx` util (for Project Crystal). The same option is used for
Webpack.

## Current Behavior
<!-- This is the behavior we have today -->

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #9199

(cherry picked from commit fdb488b)
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@nrwl/web:rollup: support for sourceMap option
2 participants