fix(nextjs): Should be able to run custom server targets with swc #27526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 696a93d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targets
Sent with 💌 from NxCloud. |
ndcunningham
force-pushed
the
fix/next-custom-server-swc
branch
2 times, most recently
from
5dcae20
to
a765474
Compare
ndcunningham
changed the title
ndcunningham
changed the title
ndcunningham
force-pushed
the
fix/next-custom-server-swc
branch
from
a765474
to
696a93d
Compare
jaysoo
approved these changes
Aug 20, 2024
FrozenPandaz
pushed a commit
that referenced
this pull request
Aug 21, 2024
…7526) ## Currently When we installed swc from the Next.js generator it installed an older version that expected version of swc this caused the node & build generator to not work. ## Expected With these changes the version will be in sync with what the `@nx/js:swc` executor is expecting. With that in mind the build should now work as expected and by extension the serve target for custom server as well. fixes: #27222 (cherry picked from commit 554e979)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
When we installed swc from the Next.js generator it installed an older version that expected version of swc this caused the node & build generator to not work.
Expected
With these changes the version will be in sync with what the
@nx/js:swcexecutor is expecting. With that in mind the build should now work as expected and by extension the serve target for custom server as well.fixes: #27222