fix(node): build-esbuild-options.ts browser user define envs by config #27480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 77cf32c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targets
Sent with 💌 from NxCloud. |
coolassassin
force-pushed
the
nx-esbuild-env-define-fix
branch
from
98444cc
to
77cf32c
Compare
jaysoo
approved these changes
Aug 16, 2024
FrozenPandaz
pushed a commit
that referenced
this pull request
Aug 19, 2024
#27480) ## Current Behavior When you use esbuild in 'browser' mode you have to provide all 'define' attributes as environment variables and only with "NX_PUBLIC_" prefix ## Expected Behavior Esbuild configuration has to work as it is described in docs. And prefix feature has to work as an additional functionality ## Related Issue(s) This issue will be fixed: #19106 Co-authored-by: Dmitrii Kamenskikh <dkamenskikh@devexperts.com> (cherry picked from commit 4941be6)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
When you use esbuild in 'browser' mode you have to provide all 'define' attributes as environment variables and only with "NX_PUBLIC_" prefix
Expected Behavior
Esbuild configuration has to work as it is described in docs. And prefix feature has to work as an additional functionality
Related Issue(s)
This issue will be fixed: #19106