Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react): enable vitejs-plugin-react-swc for swc compiler #27457

Merged

Conversation

ghost
Copy link

@ghost ghost commented Aug 15, 2024

Current Behavior

see #27433

Expected Behavior

see #27433

Related Issue(s)

see #27433

Fixes #

  • if compiler is swc, @vitejs/plugin-react-swc is being imported; otherwise @vitejs/plugin-react is being imported

@ghost ghost self-requested a review as a code owner August 15, 2024 14:54
@ghost ghost requested a review from xiongemi August 15, 2024 14:54
Copy link

vercel bot commented Aug 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Aug 15, 2024 9:56pm

@ghost ghost changed the title Bugs/enable vitejs plugin react swc fix(react): @vitejs/plugin-react-swc Aug 15, 2024
@ghost ghost force-pushed the bugs/enable-vitejs-plugin-react-swc branch 4 times, most recently from a00edd8 to 6a9c9c6 Compare August 15, 2024 15:04
@ghost ghost changed the title fix(react): @vitejs/plugin-react-swc fix(react): enable vitejs-plugin-react-swc for swc compiler Aug 15, 2024
@ghost ghost force-pushed the bugs/enable-vitejs-plugin-react-swc branch 2 times, most recently from d73d1fd to 754b8ca Compare August 15, 2024 18:54
@ghost ghost force-pushed the bugs/enable-vitejs-plugin-react-swc branch from 754b8ca to f2e6fb7 Compare August 15, 2024 20:48
@xiongemi xiongemi merged commit 7f2c556 into nrwl:master Aug 16, 2024
6 checks passed
@ghost ghost deleted the bugs/enable-vitejs-plugin-react-swc branch August 16, 2024 16:12
FrozenPandaz pushed a commit that referenced this pull request Aug 19, 2024
## Current Behavior
see #27433

## Expected Behavior
see #27433

## Related Issue(s)
see #27433

Fixes #
- if compiler is `swc`, `@vitejs/plugin-react-swc` is being imported;
otherwise `@vitejs/plugin-react` is being imported

Co-authored-by: Emily Xiong <xiongemi@gmail.com>
(cherry picked from commit 7f2c556)
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant