Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): ensure the error has message before reading indexOf #27078 #27426

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Aug 14, 2024

Current Behavior

Project graph error handling is always expecting the message property to exist on the error. This may not always be the case.

Expected Behavior

Only attempt to run indexOf if the message property exists.

Related Issue(s)

Fixes #27078

@Coly010 Coly010 requested a review from a team as a code owner August 14, 2024 11:07
@Coly010 Coly010 requested a review from Cammisuli August 14, 2024 11:07
Copy link

vercel bot commented Aug 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Aug 14, 2024 11:10am

@Coly010 Coly010 self-assigned this Aug 14, 2024
@Coly010 Coly010 merged commit c56bfbe into master Aug 14, 2024
6 checks passed
@Coly010 Coly010 deleted the core/check-error-message-exists branch August 14, 2024 15:28
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants