Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): improve the dx of the sync commands and gracefully handle exiting the prompt when running tasks #27418

Merged
merged 2 commits into from
Aug 14, 2024

Conversation

leosvelperez
Copy link
Member

  • Update the nx sync output when there are changes to sync (currently there's no output)
  • Update the nx sync and nx sync:check output when there are no changes to sync (currently there's no output)
  • Handle exiting the prompt for applying sync generator changes when running tasks

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@leosvelperez leosvelperez self-assigned this Aug 14, 2024
@leosvelperez leosvelperez requested a review from a team as a code owner August 14, 2024 07:57
Copy link

vercel bot commented Aug 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Aug 14, 2024 1:33pm

@leosvelperez leosvelperez enabled auto-merge (squash) August 14, 2024 13:31
@leosvelperez leosvelperez merged commit 8de36d7 into master Aug 14, 2024
6 checks passed
@leosvelperez leosvelperez deleted the core/improve-sync-dx branch August 14, 2024 14:27
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants