fix(module-federation): Add migration for ssr server file to run on it's own port #27411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 087da7a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targets
Sent with 💌 from NxCloud. |
jaysoo
approved these changes
Aug 13, 2024
packages/react/src/migrations/update-19-6-0/update-ssr-server-port.ts
Outdated
Show resolved
Hide resolved
packages/react/src/migrations/update-19-6-0/update-ssr-server-port.ts
Outdated
Show resolved
Hide resolved
packages/react/src/migrations/update-19-6-0/update-ssr-server-port.spec.ts
Outdated
Show resolved
Hide resolved
jaysoo
reviewed
Aug 13, 2024
packages/react/src/migrations/update-19-6-0/update-ssr-server-port.spec.ts
Outdated
Show resolved
Hide resolved
ndcunningham
force-pushed
the
fix/mfe-add-migration-for-react-ssr
branch
2 times, most recently
from
41e94ac
to
a928915
Compare
jaysoo
reviewed
Aug 14, 2024
jaysoo
force-pushed
the
fix/mfe-add-migration-for-react-ssr
branch
from
a928915
to
f65f3d2
Compare
ndcunningham
force-pushed
the
fix/mfe-add-migration-for-react-ssr
branch
3 times, most recently
from
b08f9a3
to
2ffd5fb
Compare
ndcunningham
force-pushed
the
fix/mfe-add-migration-for-react-ssr
branch
from
2ffd5fb
to
087da7a
Compare
4 tasks
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Currently, if you have a SSR Mfe project and you run multiple ssr projects using the 'serve' target it would fail due to conflicting ports unless explicitly set
PORT=4202 node dist/acme/server.js.Expected Behavior
Now the default is to have the server take the same port as it was generated with so that if you run multiple server apps that depends on other apps in dev mode there will be no conflicts.
Related Issue(s)
Fixes #