Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module-federation): optimization should not be overwritten #27201 #27376

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Aug 12, 2024

Current Behavior

withModuleFederation is overwriting config.optimization rather than merging it.

Expected Behavior

config.optimization should be merged

Related Issue(s)

Fixes #27201

@Coly010 Coly010 requested a review from a team as a code owner August 12, 2024 10:10
@Coly010 Coly010 requested a review from xiongemi August 12, 2024 10:10
@Coly010 Coly010 self-assigned this Aug 12, 2024
Copy link

vercel bot commented Aug 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Aug 12, 2024 10:12am

@Coly010 Coly010 merged commit f208acd into master Aug 12, 2024
6 checks passed
@Coly010 Coly010 deleted the module-federation/merge-optimization-options branch August 12, 2024 14:29
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

withModuleFederation plugin overwrites config.optimization options
2 participants