Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nextjs): Fix order, and wrong number call to createWebpackConfig() #27337

Merged
merged 4 commits into from
Aug 14, 2024

Conversation

tvdoan
Copy link
Contributor

@tvdoan tvdoan commented Aug 8, 2024

Current Behavior

Assets are not copied to the dist folder after running @nx/next:build

Expected Behavior

Assets should be copied to the dist folder after @nx/next:build

Related Issue(s)

#26900

Fixes #
Fix the order, and wrong number of parameters call to createWebpackConfig()

@tvdoan tvdoan requested a review from a team as a code owner August 8, 2024 13:25
@tvdoan tvdoan requested a review from mandarini August 8, 2024 13:25
Copy link

vercel bot commented Aug 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Aug 13, 2024 11:55pm

Copy link
Contributor

@ndcunningham ndcunningham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexandr2110pro
Copy link

Hey guys. When can we expect it to be released?

@jaysoo jaysoo merged commit 22b654a into nrwl:master Aug 14, 2024
6 checks passed
@jaysoo
Copy link
Member

jaysoo commented Aug 14, 2024

19.6 should be today

@tvdoan tvdoan deleted the bugfix/fix-withnx branch August 15, 2024 02:11
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants