Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module-federation): add nx-runtime-library-control-plugin #26816

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Jul 3, 2024

  • feat(module-federation): use @module-federation/enhanced for withModuleFederation
  • feat(module-federation): expose API for users to override module federation plugin options
  • fix(module-federation): angular mf ssr projects should not create vendor chunks
  • feat(module-federation): add nx-runtime-library-control-plugin

Current Behavior

A common occurrence when working with NX Module Federation is that a shared library may get resolved from a static remote.
Any changes to the shared lib are therefore not reflected in the dev server.

Expected Behavior

Add the nx-runtime-library-control-plugin to ensure that shared libraries are shared from a remote that is served via webpack-dev-server.

Related Issue(s)

Fixes #11615

@Coly010 Coly010 self-assigned this Jul 3, 2024
Copy link

vercel bot commented Jul 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Jul 18, 2024 1:21am

@Coly010 Coly010 force-pushed the mf/library-control-plugin branch 3 times, most recently from 9360ac1 to 51699f9 Compare July 3, 2024 16:24
Copy link

github-actions bot commented Jul 3, 2024

🐳 We have a release for that!

This PR has a release associated with it. You can try it out using this command:

npx create-nx-workspace@0.0.0-pr-26816-51699f9 my-workspace

Or just copy this version and use it in your own command:

0.0.0-pr-26816-51699f9
Release details 📑
Published version 0.0.0-pr-26816-51699f9
Triggered by @jaysoo
Branch mf/library-control-plugin
Commit 51699f9
Workflow run 9782047745

To request a new release for this pull request, mention someone from the Nx team or the @nrwl/nx-pipelines-reviewers.

@jaysoo jaysoo force-pushed the mf/library-control-plugin branch from 51699f9 to de407f8 Compare July 17, 2024 12:27
@jaysoo jaysoo force-pushed the mf/library-control-plugin branch from de407f8 to cde0c7d Compare July 17, 2024 14:16
@jaysoo jaysoo marked this pull request as ready for review July 17, 2024 14:16
@jaysoo jaysoo requested review from jaysoo and a team as code owners July 17, 2024 14:17
@jaysoo jaysoo requested a review from FrozenPandaz July 17, 2024 14:17
@jaysoo jaysoo force-pushed the mf/library-control-plugin branch from cde0c7d to e5e1a62 Compare July 17, 2024 14:19
@jaysoo jaysoo merged commit 483bcf3 into master Jul 18, 2024
6 checks passed
@jaysoo jaysoo deleted the mf/library-control-plugin branch July 18, 2024 02:46
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dev remotes appears to only work with the last alphabetized remote.
2 participants