fix(core): name collisions during project inference should not error out if corrected by a project.json's name #18665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…out if corrected by a project.json's name
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
AgentEnder
commented
Aug 17, 2023
| @@ -7,7 +7,6 @@ Context for [CreateNodesFunction](../../devkit/documents/CreateNodesFunction) | |||
| ### Properties | |||
|
|
|||
| - [nxJsonConfiguration](../../devkit/documents/CreateNodesContext#nxjsonconfiguration) | |||
| - [projectsConfigurations](../../devkit/documents/CreateNodesContext#projectsconfigurations) | |||
There was a problem hiding this comment.
We don't have access to these any more in the area where we call createNodes, and doing so could incur a significant perf hit. I don't think its a big deal to drop this, since the API isn't documented yet and is still experimental.
FrozenPandaz
approved these changes
Aug 17, 2023
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Project's inferred from a project inference plugin are merged with any other configurations, but if the inferred configuration has a name which is inferred to be the same as another project's name, it can cause an issue when reading the project.json for that project later on.
Expected Behavior
No errors occur if there are project.jsons that specify unique names
Related Issue(s)
Fixes #18660
Fixes #18668