Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(nextjs): make next build package manager agnostic #18661

Merged
merged 1 commit into from
Aug 17, 2023
Merged

fix(nextjs): make next build package manager agnostic #18661

merged 1 commit into from
Aug 17, 2023

Conversation

ndcunningham
Copy link
Contributor

What has changed:

Instead of running different build commands based on the package manager we can invoke the command directly from the bin.

closed #18653

@ndcunningham ndcunningham added the scope: nextjs Issues related to NextJS support for Nx label Aug 16, 2023
@ndcunningham ndcunningham requested a review from a team as a code owner August 16, 2023 18:53
@ndcunningham ndcunningham self-assigned this Aug 16, 2023
@vercel
Copy link

vercel bot commented Aug 16, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 17, 2023 4:05pm

@nx-cloud
Copy link

nx-cloud bot commented Aug 16, 2023 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit db3c52d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 8 targets

Sent with 💌 from NxCloud.

@ndcunningham ndcunningham requested a review from a team as a code owner August 16, 2023 19:34
meeroslav
meeroslav requested changes Aug 17, 2023
View reviewed changes
Copy link
Contributor

@meeroslav meeroslav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few minor changes needed, otherwise it's good.

@ndcunningham ndcunningham enabled auto-merge (squash) August 17, 2023 15:51
@ndcunningham ndcunningham merged commit 2e1bccd into nrwl:master Aug 17, 2023
3 checks passed
FrozenPandaz pushed a commit that referenced this pull request Aug 18, 2023
@ndcunningham @FrozenPandaz
fix(nextjs): make next build package manager agnostic (#18661)
bcaecfd 
(cherry picked from commit 2e1bccd)
@timonmasberg timonmasberg mentioned this pull request Aug 19, 2023
Merged
@github-actions github-actions bot mentioned this pull request Aug 19, 2023
Closed
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@meeroslav meeroslav meeroslav approved these changes

@xiongemi xiongemi xiongemi approved these changes

@jaysoo jaysoo Awaiting requested review from jaysoo jaysoo is a code owner automatically assigned from nrwl/nx-react-reviewers

Assignees

@ndcunningham ndcunningham

Labels
scope: nextjs Issues related to NextJS support for Nx
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@nx/next 16.7.0 - "Invalid project directory provided, no such directory"
3 participants
@ndcunningham @meeroslav @xiongemi