Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storybook): correctly identify if uses vite-based framework #17465

Merged
merged 1 commit into from
Jun 7, 2023

Conversation

mandarini
Copy link
Member

Current Behavior

Storybook configuration generator will only add vite-related builder config in .storybook/main.js if project has vite build target.

Expected Behavior

Storybook configuration generator should also add vite-related builder config in .storybook/main.js if project uses vite based Storybook framework.

@mandarini mandarini requested a review from a team as a code owner June 7, 2023 15:02
@mandarini mandarini requested a review from Coly010 June 7, 2023 15:02
@mandarini mandarini self-assigned this Jun 7, 2023
@vercel
Copy link

vercel bot commented Jun 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 7, 2023 3:04pm

@mandarini mandarini merged commit 4819264 into nrwl:master Jun 7, 2023
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants