Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(js): pass buildTargetOptions in executor #17459

Merged
merged 1 commit into from
Jun 7, 2023

Conversation

mandarini
Copy link
Member

closed #17429

Current Behavior

Only project.data.targets[buildTarget.target]?.options is used and additional options passed through buildTargetOptions are ignored.

Expected Behavior

Pass buildTargetOptions too.

Related Issue(s)

Fixes #17429

@mandarini mandarini requested a review from a team as a code owner June 7, 2023 08:40
@vercel
Copy link

vercel bot commented Jun 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 7, 2023 8:43am

@jaysoo jaysoo merged commit 392366f into nrwl:master Jun 7, 2023
jaysoo pushed a commit to jaysoo/nx that referenced this pull request Jun 7, 2023
jaysoo pushed a commit to jaysoo/nx that referenced this pull request Jun 7, 2023
jaysoo pushed a commit to jaysoo/nx that referenced this pull request Jun 7, 2023
juristr pushed a commit to juristr/nx that referenced this pull request Jun 7, 2023
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@nx/js:node executor ignores buildTargetOptions in version 16.3.0
2 participants