fix(js): do not overwrite supported typescript version #17350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
leosvelperez
force-pushed
the
misc/supported-ts-versions
branch
from
0257c8e
to
5528dc8
Compare
|
As this popped up for Angular, would you mind also fixing this for other packages? Maybe a more general approach would be then necessary. "ng-packagr" is simply overwritten in the angular library generator and does not care about the currently installed version either. https://github.com/nrwl/nx/blob/master/packages/angular/src/generators/library/library.ts#L100 I know it does not really relate to this MR. If you prefer I can create a new issue instead. EDIT: Thanks for fixing it :) |
leosvelperez
force-pushed
the
misc/supported-ts-versions
branch
from
5528dc8
to
87a0922
Compare
leosvelperez
force-pushed
the
misc/supported-ts-versions
branch
from
87a0922
to
1f437c1
Compare
mandarini
approved these changes
Jun 1, 2023
FrozenPandaz
pushed a commit
that referenced
this pull request
Jun 2, 2023
(cherry picked from commit c68b4bf)
Closed
4 tasks
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
The
@nx/js:initgenerator always sets thetypescriptpackage version to the latest supported version. This causes issues where an older supported version is needed in the workspace (e.g. when using an older supported version of Angular).Expected Behavior
The
@nx/js:initgenerator should not overwrite thetypescriptpackage version if it's a supported version.Related Issue(s)
Fixes #17344