-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
serve-static target should not be created without e2e config #27854
Labels
Comments
The serve static target is useful for other scenarios:
It is not constrained to just I'll make a slight change to how and where it is set up to reflect this. |
Coly010
added a commit
that referenced
this issue
Sep 16, 2024
Coly010
added a commit
that referenced
this issue
Sep 16, 2024
<!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior <!-- This is the behavior we have today --> The `serve-static` target is being added in the `add-e2e` file, however, it has uses beyond e2e. ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> The `serve-static` target should be added with more intention ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #27854
FrozenPandaz
pushed a commit
that referenced
this issue
Sep 18, 2024
<!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior <!-- This is the behavior we have today --> The `serve-static` target is being added in the `add-e2e` file, however, it has uses beyond e2e. ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> The `serve-static` target should be added with more intention ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #27854 (cherry picked from commit d723326)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Current Behavior
nx g @nx/angular:application app123 --directory apps --bundler=esbuild --ssr=false --projectNameAndRootFormat=derived
Expected Behavior
nx g @nx/angular:application app123 --directory apps --bundler=esbuild --ssr=false --projectNameAndRootFormat=derived
GitHub Repo
No response
Steps to Reproduce
Nx Report
Failure Logs
No response
Package Manager Version
No response
Operating System
Additional Information
The code that needs to be moved:
nx/packages/angular/src/generators/application/lib/add-e2e.ts
Line 31 in 320d9f2
Pull request opened: #27853
The text was updated successfully, but these errors were encountered: