Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Angular Incremental Builds recipe to reflect needed executors for esbuild #27716

Closed
2 of 4 tasks
mhelm306 opened this issue Aug 30, 2024 · 0 comments · Fixed by #27952
Closed
2 of 4 tasks

Update Angular Incremental Builds recipe to reflect needed executors for esbuild #27716

mhelm306 opened this issue Aug 30, 2024 · 0 comments · Fixed by #27952
Assignees
@Coly010
Labels
scope: angular Issues related to Angular support in Nx type: docs

Comments

@mhelm306
Copy link

Documentation issue

  • Reporting a typo
  • Reporting a documentation bug
  • Documentation improvement
  • Documentation feedback

Is there a specific documentation page you are reporting?

https://nx.dev/recipes/angular/setup-incremental-builds-angular

Additional context or description

The current documentation for setting up incremental angular builds is specific to webpack. Since Angular 18 has switched to esbuild as the default, it's not clear is the same packagers should be used for the buildable libraries. Some clarification on what executors would be used for an incrementally building angular mono-repo using esbuild would be appreciated
@Coly010 Coly010 self-assigned this Sep 17, 2024
@Coly010 Coly010 added the scope: angular Issues related to Angular support in Nx label Sep 17, 2024
@Coly010 Coly010 mentioned this issue Sep 17, 2024
Merged
FrozenPandaz pushed a commit that referenced this issue Sep 18, 2024
@Coly010 @FrozenPandaz
docs(angular): add esbuild information to incremental builds (#27952)
54bc994 
<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

## Current Behavior
<!-- This is the behavior we have today -->
Setup angular incremental builds doc does not contain info on esbuild

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->
Add information about using incremental builds with angular.
Also callout that the performance gain may not be as effective as it was
with webpack

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #27716

(cherry picked from commit 2be7424)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Coly010 Coly010

Labels
scope: angular Issues related to Angular support in Nx type: docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs(angular): add esbuild information to incremental builds nrwl/nx
2 participants
@Coly010 @mhelm306