Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The 'implicitDependencies' option in mf does not work. #27448

Closed
1 of 4 tasks
EnochGao opened this issue Aug 15, 2024 · 8 comments · Fixed by #27472
Closed
1 of 4 tasks

The 'implicitDependencies' option in mf does not work. #27448

EnochGao opened this issue Aug 15, 2024 · 8 comments · Fixed by #27472
Assignees
@Coly010
Labels
scope: angular Issues related to Angular support in Nx scope: module federation Issues related to module federation support type: bug

Comments

@EnochGao
Copy link

Current Behavior

The 'implicitDependencies' option in mf does not work.
image
image

Expected Behavior

work fine

GitHub Repo

https://github.com/EnochGao/nx-test/tree/mf

Steps to Reproduce

npx nx build host check the dist folder

Nx Report

Node           : 20.14.0
OS             : linux-x64
Native Target  : x86_64-linux
npm            : 10.7.0

nx                 : 19.5.7
@nx/js             : 19.5.7
@nx/jest           : 19.5.7
@nx/linter         : 19.5.7
@nx/eslint         : 19.5.7
@nx/workspace      : 19.5.7
@nx/angular        : 19.5.7
@nx/devkit         : 19.5.7
@nx/eslint-plugin  : 19.5.7
@nrwl/tao          : 19.5.7
@nx/web            : 19.5.7
@nx/webpack        : 19.5.7
typescript         : 5.5.3

Failure Logs

No response

Package Manager Version

No response

Operating System

  • macOS
  • Linux
  • Windows
  • Other (Please specify)

Additional Information

No response
@EnochGao EnochGao mentioned this issue Aug 15, 2024
Closed
4 tasks
@Coly010 Coly010 self-assigned this Aug 15, 2024
@Coly010
Copy link
Contributor

Coly010 commented Aug 15, 2024 •
edited
Loading

As a workaround for now, add dependsOn: ["^build"] to the targetDefaults.@nx/angular:webpack-browser entry

@leosvelperez leosvelperez added scope: angular Issues related to Angular support in Nx scope: module federation Issues related to module federation support labels Aug 16, 2024
Coly010 added a commit that referenced this issue Aug 16, 2024
@Coly010
fix(module-federation): ensure target defaults are set correctly #27448
196e426
@Coly010 Coly010 mentioned this issue Aug 16, 2024
Merged
Coly010 added a commit that referenced this issue Aug 16, 2024
@Coly010
fix(module-federation): ensure target defaults are set correctly #27448
d8b37c5
FrozenPandaz pushed a commit that referenced this issue Aug 19, 2024
@Coly010 @FrozenPandaz
fix(module-federation): ensure target defaults are set correctly #27448…
b621454 
… (#27472)

<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

## Current Behavior
<!-- This is the behavior we have today -->
Target Defaults set up for the Module Federation builds is incorrect or
missing.

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->
Target Defaults for Module Federation builds is set up correctly

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #27448

(cherry picked from commit 396a5de)
@EnochGao
Copy link
Author

@Coly010 I upgraded to version 19.16.1, but it doesn't seem to be working

@Coly010
Copy link
Contributor

Coly010 commented Aug 20, 2024

@EnochGao Can you give any additional information at all? It's very difficult to help solve issues when comments are vague

@EnochGao
Copy link
Author

EnochGao commented Aug 20, 2024 •
edited
Loading

@Coly010
Thank you for your reply. I upgraded the current branch and run npx nx build host. The child project was not built. Does dependsOn: ["^build"] in the targetDefaults option of host still need to be configured in version 19.6.1?

@EnochGao
Copy link
Author

Upgrading to version 19.7.0-beta.1 also does not take effect

@EnochGao
Copy link
Author

@leosvelperez

@juristr juristr mentioned this issue Aug 26, 2024
Merged
@EnochGao
Copy link
Author

@Coly010

@Coly010
Copy link
Contributor

Coly010 commented Aug 28, 2024

@Coly010 Thank you for your reply. I upgraded the current branch and run npx nx build host. The child project was not built. Does dependsOn: ["^build"] in the targetDefaults option of host still need to be configured in version 19.6.1?

Yes. The target default isn’t added automatically to existing workspaces, unless the application generator is run again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Coly010 Coly010

Labels
scope: angular Issues related to Angular support in Nx scope: module federation Issues related to module federation support type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(module-federation): ensure target defaults are set correctly #27448 nrwl/nx
3 participants
@leosvelperez @Coly010 @EnochGao