fix(module-federation): remote proxies should use https when host is …

…configured with ssl #27360
nrwl · Aug 12, 2024 · ecc3d03 · ecc3d03
1 parent 8bba5b5
commit ecc3d03
Show file tree

Hide file tree

Showing 4 changed files with 50 additions and 7 deletions.
diff --git a/packages/angular/src/executors/module-federation-dev-server/lib/normalize-options.ts b/packages/angular/src/executors/module-federation-dev-server/lib/normalize-options.ts
@@ -4,6 +4,8 @@ import type {
   SchemaWithBrowserTarget,
   SchemaWithBuildTarget,
 } from '../schema';
+import { join } from 'path';
+import { workspaceRoot } from '@nx/devkit';
 
 export function normalizeOptions(schema: Schema): NormalizedSchema {
   let buildTarget = (schema as SchemaWithBuildTarget).buildTarget;
@@ -24,5 +26,7 @@ export function normalizeOptions(schema: Schema): NormalizedSchema {
     liveReload: schema.liveReload ?? true,
     open: schema.open ?? false,
     ssl: schema.ssl ?? false,
+    sslCert: schema.sslCert ? join(workspaceRoot, schema.sslCert) : undefined,
+    sslKey: schema.sslKey ? join(workspaceRoot, schema.sslKey) : undefined,
   };
 }
diff --git a/...s/angular/src/executors/module-federation-dev-server/module-federation-dev-server.impl.ts b/...s/angular/src/executors/module-federation-dev-server/module-federation-dev-server.impl.ts
@@ -156,7 +156,16 @@ export async function* moduleFederationDevServerExecutor(
     options
   );
 
-  startRemoteProxies(staticRemotesConfig, mappedLocationsOfStaticRemotes);
+  startRemoteProxies(
+    staticRemotesConfig,
+    mappedLocationsOfStaticRemotes,
+    options.ssl
+      ? {
+          pathToCert: options.sslCert,
+          pathToKey: options.sslKey,
+        }
+      : undefined
+  );
 
   const removeBaseUrlEmission = (iter: AsyncIterable<unknown>) =>
     mapAsyncIterable(iter, (v) => ({

diff --git a/...ges/react/src/executors/module-federation-dev-server/module-federation-dev-server.impl.ts b/...ges/react/src/executors/module-federation-dev-server/module-federation-dev-server.impl.ts
@@ -365,7 +365,16 @@ export default async function* moduleFederationDevServer(
     options
   );
 
-  startRemoteProxies(staticRemotesConfig, mappedLocationsOfStaticRemotes);
+  startRemoteProxies(
+    staticRemotesConfig,
+    mappedLocationsOfStaticRemotes,
+    options.ssl
+      ? {
+          pathToCert: join(workspaceRoot, options.sslCert),
+          pathToKey: join(workspaceRoot, options.sslKey),
+        }
+      : undefined
+  );
 
   return yield* combineAsyncIterables(
     currIter,

diff --git a/packages/webpack/src/utils/module-federation/start-remote-proxies.ts b/packages/webpack/src/utils/module-federation/start-remote-proxies.ts
@@ -1,25 +1,46 @@
 import type { Express } from 'express';
-import { logger } from '@nx/devkit';
+import { logger, ProjectGraph } from '@nx/devkit';
 import { StaticRemotesConfig } from './parse-static-remotes-config';
+import { existsSync, readFileSync } from 'fs';
 
 export function startRemoteProxies(
   staticRemotesConfig: StaticRemotesConfig,
-  mappedLocationsOfRemotes: Record<string, string>
+  mappedLocationsOfRemotes: Record<string, string>,
+  sslOptions?: { pathToCert: string; pathToKey: string }
 ) {
   const { createProxyMiddleware } = require('http-proxy-middleware');
   const express = require('express');
+  let sslCert: Buffer;
+  let sslKey: Buffer;
+  if (sslOptions && sslOptions.pathToCert && sslOptions.pathToKey) {
+    if (existsSync(sslOptions.pathToCert) && existsSync(sslOptions.pathToKey)) {
+      sslCert = readFileSync(sslOptions.pathToCert);
+      sslKey = readFileSync(sslOptions.pathToKey);
+    } else {
+      logger.warn(
+        `Encountered SSL options in project.json, however, the certificate files do not exist in the filesystem. Using http.`
+      );
+      logger.warn(
+        `Attempted to find '${sslOptions.pathToCert}' and '${sslOptions.pathToKey}'.`
+      );
+    }
+  }
+  const http = require('http');
+  const https = require('https');
+
   logger.info(`NX Starting static remotes proxies...`);
   for (const app of staticRemotesConfig.remotes) {
     const expressProxy: Express = express();
     expressProxy.use(
       createProxyMiddleware({
         target: mappedLocationsOfRemotes[app],
         changeOrigin: true,
+        secure: sslCert ? false : undefined,
       })
     );
-    const proxyServer = expressProxy.listen(
-      staticRemotesConfig.config[app].port
-    );
+    const proxyServer = (sslCert ? https : http)
+      .createServer({ cert: sslCert, key: sslKey }, expressProxy)
+      .listen(staticRemotesConfig.config[app].port);
     process.on('SIGTERM', () => proxyServer.close());
     process.on('exit', () => proxyServer.close());
   }