fix(storybook): update version check

Previously the check would see if the version of storybook is less than 7 and would throw an error. This causes an issue when testing canary releases of storybook since they are labeled 0.0.0-[pr-info...] Update pleaseUpgrade text One of the checks is to see if storybook is less than 7. The text is updated so it matches for the very unlikely scenario that someone with version 5 and lower runs this plugin.
nrwl · Aug 2, 2024 · afa3fa4 · afa3fa4
1 parent 97d4184
commit afa3fa4
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/packages/storybook/src/executors/storybook/storybook.impl.ts b/packages/storybook/src/executors/storybook/storybook.impl.ts
@@ -14,8 +14,10 @@ export default async function* storybookExecutor(
   success: boolean;
   info?: { port: number; baseUrl?: string };
 }> {
-  const storybook7 = storybookMajorVersion() >= 7;
-  if (!storybook7) {
+  const sbVersion = storybookMajorVersion();
+  const sbLessThan7 = sbVersion >= 7 && sbVersion > 0;
+
+  if (!sbLessThan7) {
     throw pleaseUpgrade();
   }
   storybookConfigExistsCheck(options.configDir, context.projectName);

diff --git a/packages/storybook/src/utils/utilities.ts b/packages/storybook/src/utils/utilities.ts
@@ -268,7 +268,7 @@ export function getTsSourceFile(host: Tree, path: string): ts.SourceFile {
 
 export function pleaseUpgrade(): string {
   return `
-    Storybook 6 is no longer maintained, and not supported in Nx. 
+    Storybook 6 and lower are no longer maintained, and not supported in Nx. 
     Please upgrade to Storybook 7.
 
     Here is a guide on how to upgrade: