Skip to content

Commit

Permalink
fix(core): ensure context is available when updating files in context
Browse files Browse the repository at this point in the history
  • Loading branch information
FrozenPandaz committed Aug 13, 2024
1 parent c72ba9b commit 95898f2
Show file tree
Hide file tree
Showing 3 changed files with 19 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,11 @@ async function processFilesAndCreateAndSerializeProjectGraph(
performance.mark('hash-watched-changes-start');
const updatedFiles = [...collectedUpdatedFiles.values()];
const deletedFiles = [...collectedDeletedFiles.values()];
let updatedFileHashes = updateFilesInContext(updatedFiles, deletedFiles);
let updatedFileHashes = updateFilesInContext(
workspaceRoot,
updatedFiles,
deletedFiles
);
performance.mark('hash-watched-changes-end');
performance.measure(
'hash changed files from watcher',
Expand Down
7 changes: 6 additions & 1 deletion packages/nx/src/utils/sync-generators.ts
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,12 @@ async function flushSyncGeneratorChangesToDisk(
}

// Update the context files
await updateContextWithChangedFiles(createdFiles, updatedFiles, deletedFiles);
await updateContextWithChangedFiles(
workspaceRoot,
createdFiles,
updatedFiles,
deletedFiles
);
performance.mark('flush-sync-generator-changes-to-disk:end');
performance.measure(
'flush sync generator changes to disk',
Expand Down
9 changes: 8 additions & 1 deletion packages/nx/src/utils/workspace-context.ts
Original file line number Diff line number Diff line change
Expand Up @@ -75,12 +75,17 @@ export async function hashWithWorkspaceContext(
}

export async function updateContextWithChangedFiles(
workspaceRoot: string,
createdFiles: string[],
updatedFiles: string[],
deletedFiles: string[]
) {
if (!daemonClient.enabled()) {
updateFilesInContext([...createdFiles, ...updatedFiles], deletedFiles);
updateFilesInContext(
workspaceRoot,
[...createdFiles, ...updatedFiles],
deletedFiles
);
} else if (isOnDaemon()) {
// make sure to only import this when running on the daemon
const { addUpdatedAndDeletedFiles } = await import(
Expand All @@ -99,9 +104,11 @@ export async function updateContextWithChangedFiles(
}

export function updateFilesInContext(
workspaceRoot: string,
updatedFiles: string[],
deletedFiles: string[]
) {
ensureContextAvailable(workspaceRoot);
return workspaceContext?.incrementalUpdate(updatedFiles, deletedFiles);
}

Expand Down

0 comments on commit 95898f2

Please sign in to comment.