-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(vite): plugin should infer serve target if server config defined #…
…27370 (#27507) <!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior <!-- This is the behavior we have today --> Vite Plugin was originally only checking if the `lib` option was defined in a vite config, and using that to avoid inferring serve targets. ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> Some libraries may still need a serve target, and if they have a server config defined, the serve target should be inferred ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #27370 (cherry picked from commit 08fc13d)
- Loading branch information
1 parent
d179bcd
commit 6a5564c
Showing
2 changed files
with
164 additions
and
17 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters