Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/sofie 3196/bump node #19

Merged
merged 2 commits into from
Aug 8, 2024
Merged

Feat/sofie 3196/bump node #19

merged 2 commits into from
Aug 8, 2024

Conversation

jesperstarkar
Copy link
Contributor

About the Contributor

This pull request is posted on behalf of the NRK.

Type of Contribution

This is a:

Version bump

Current Behavior

Project references Node 16.

New Behavior

Following #18, the project should track Electron's Node version and use 20

Testing Instructions

Other Information

Status

Kinda naive attempt - don't know much about this, just global searched and changed some values.

  • PR is ready to be reviewed.
  • The functionality has been tested by the author.
  • Relevant unit tests has been added / updated.
  • Relevant documentation (code comments, system documentation) has been added / updated.

@jesperstarkar jesperstarkar requested review from Julusian, nytamin and a team and removed request for Julusian and nytamin August 8, 2024 08:03
Copy link
Member

@Julusian Julusian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using 16 before was an interesting choice, that is not what electron wanted so I don't know where that came from

@jesperstarkar jesperstarkar merged commit 9ec548e into main Aug 8, 2024
2 checks passed
@jesperstarkar jesperstarkar deleted the feat/SOFIE-3196/bump-node branch August 8, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants