Check for endianness definitions in IAEA utilities #1152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think that this is ok, since the value of these constants is never used per se in the IAEA phsp code, it is just a label, so to speak. |
ftessier
approved these changes
Jun 10, 2024
|
For the record, I did double-check that the macOS versions have the same definitions, not that it matters. |
rtownson
approved these changes
Aug 9, 2024
blakewalters
approved these changes
Aug 14, 2024
mainegra
approved these changes
Sep 5, 2024
This gets rid of compilation warnings that LITTLE_ENDIAN, BIG_ENDIAN, and PDP_ENDIAN were already defined on macOS.
rtownson
force-pushed
the
check-endianness
branch
from
941969f
to
5c86db3
Compare
|
Tweaked commit message. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gets rid of compilation warnings that
LITTLE_ENDIAN,BIG_ENDIAN, andPDP_ENDIANwere already defined on macOS.This is the same as the previous pull request I had opened #1142; I just renamed my branch to better keep track of things.