egs_fluence_scoring: Fix several bugs #1105
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Total fluence normalization bug during output: expression norm /= volume[k]; reduces normalization for F[k] by V[k-1]*V[k-2]*...*V[1] changed to norm = norma/volume[k]; - Eliminate misleading message in fluence scoring When scoring photon fluence, no message related to electron fluence calculation method should be issued. Thanks to Alexandra Bourgouin for drawing my attention to this issue! Fixes issue #1002 - Read user-requested normalization not only when differential fluence requested as it is also needed for integral fluence
|
That is great, I encountered an issue with fluence normalization recently. I bet this solves it, will check. |
Can't believe these "fixes" were already made last Summer! Time flies when one is having fun! |
rtownson
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
norm /= volume[k];reduces normalization for$ \Phi[k]$ by $V[k-1]*V[k-2]*...*V[1] $
changed to
norm = norma/volume[k];Fix issue Eliminate misleading message in fluence scoring AO #1002
Read user-requested normalization not only when differential fluence requested as it is also needed for integral fluence