Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a c++14 mingw compiler error and some warnings #1082

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

rtownson
Copy link
Collaborator

Fix a compiler error and some warnings found when compiling with mingw on windows, gcc 13.2.0. Note that currently users need to add -std=c++14 manually by editing the g++ settings in the installer, when installing with modern compilers that default to a newer standard. This should get resolved automatically at the next release when the installer is updated to include c++14 by default.

@mchamberland
Copy link
Contributor

I've been struggling with installing on Windows these past two weeks. Will give that a shot!

@mchamberland
Copy link
Contributor

mchamberland commented Dec 1, 2023

It looks like inputting the -std=c++14 option in the 'Standard options' text field of the g++ settings in the configure Windows application gets ignored. I had to put it under the 'Optimization options' for it to get picked up. Is that a bug?

@rtownson
Copy link
Collaborator Author

rtownson commented Dec 1, 2023

It looks like inputting the -std=c++14 option in the 'Standard options' text field of the g++ settings in the configure Windows application gets ignored. I had to put it under the 'Optimization options' for it to get picked up. Is that a bug?

Sounds like a bug!

@mchamberland
Copy link
Contributor

I don't really understand all of the egs_configure code, but I don't see where the standard g++ options get used. I can see the optimization options getting used in the create_egspp_config(), though.

@mchamberland
Copy link
Contributor

Also, this PR appears to work as advertised: I was able to compile on Windows with mingw, gcc13.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants