Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix egs_circle_perpendicular critical bug #1072

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Fix egs_circle_perpendicular critical bug #1072

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions HEN_HOUSE/egs++/shapes/egs_circle_perpendicular/egs_circle_perpendicular.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,9 +149,8 @@ class EGS_CIRCLE_PERPENDICULAR_EXPORT EGS_CirclePerpendicularShape : public EGS_
EGS_Float angleBetween = std::acos(u * perpToCircle / (perpToCircle.length() * u.length()));

// We will rotate about a vector perpendicular to u and the target surface normal
// Check against fabs(u.z) to account for both parallel and anti-parallel cases
EGS_Vector rotateAbout;
if ((fabs(u.z) - perpToCircle.z) < epsilon) {
if (fabs(fabs(u.z) - perpToCircle.z) < epsilon) {
rotateAbout = perpToCircle;
}
else {
Expand Down