Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix egs xyzrepeater bug #1069

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Fix egs xyzrepeater bug #1069

merged 1 commit into from
Sep 4, 2024

Conversation

mainegra
Copy link
Contributor 

Fix bug in EGS_XYZRepeater hownear

- Typo in hownear when particle in bounding box determining which of
  the repeated geometries to check:

  Using nz rather than nxy when computing index of repeated geometry array
  results in addressing array index out of bounds with subsequent segfault error.

  Showed when eletron transport turned ON up during dose calculations around
  a CivaDot source using egs_dose_scoring and egs_app and 2 microns regions.

  It did not affect photon-only nor egs_kerma calculations since there is no
  call to hownear. ;-)

@mainegra mainegra self-assigned this Oct 20, 2023
@mainegra mainegra requested a review from a team as a code owner October 20, 2023 13:52
@mainegra mainegra changed the base branch from master to develop October 20, 2023 13:54
@rtownson rtownson added this to the Release 2024 milestone Jan 24, 2024
@ftessier ftessier assigned ftessier and unassigned mainegra Aug 9, 2024
@ftessier ftessier assigned mainegra and unassigned ftessier Aug 9, 2024
@mainegra @rtownson
Fix bug in EGS_XYZRepeater hownear
346b745 
Fix typo in hownear when particle in bounding box determining which
of the repeated geometries to check:

Using nz rather than nxy when computing index of repeated geometry array
results in addressing array index out of bounds with subsequent
segfault error.

Showed when electron transport turned ON up during dose calculations
around a CivaDot source using egs_dose_scoring and egs_app and 2 microns
regions.

It did not affect photon-only nor egs_kerma calculations since there is
no call to hownear. ;-)
@rtownson
Copy link
Collaborator

rtownson commented Sep 4, 2024

Tweaked commit message.

@rtownson rtownson merged commit f9c0ff6 into develop Sep 4, 2024
@rtownson rtownson deleted the fix-egs_xyzrepeater-bug branch September 4, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ftessier ftessier ftessier approved these changes

@rtownson rtownson rtownson approved these changes

@blakewalters blakewalters blakewalters approved these changes

Assignees

@mainegra mainegra

Labels
bug critical
Projects
None yet
Milestone
Release 2024
Development

Successfully merging this pull request may close these issues.
4 participants
@mainegra @rtownson @ftessier @blakewalters