Add triangular mesh support and octree acceleration #1057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of a less-than comparison of the minimum interior and exterior distances, less-or-equal is required to correctly implement isWhere. Rays intersecting the mesh exactly on the corner can lead to a case where the minimum interior distance and minimum exterior distance are equal. If this occurs, it should be counted as outside the mesh, otherwise, extra dose is wrongly attributed to the mesh region.
This will be extended in future commits to a full octree.
Adding the octree accelerated version of the howfar, iswhere and hownear geometric egs methods. Several previously unnoticed bugs have been fixed: 1) enveloppe bug fix improved by adding infinitesmal amount (1e-08) around dist=0 2) corrected bug where not all triangles would be added to any suboctant, which is a problem since they must be contained in at least one suboctant if they are contained in the octant Also, left some debugging outputs listing the number of geometric checks on a triangle by a given method for both the naive and octree accelerated case (changes to application, genveloppe and gtransform are simply to be able to output these at the end of the simulation and will be removed in a future commit)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for STL triangular meshes, thanks to @mxxo. Also adds octree acceleration to the implementation, similar to egs_mesh, thanks to @a-l-demelo.
There is still an outstanding bug in the mesh code, so do not expect correct results yet. This is a draft pull request.