Fix radiative splitting ao #1011
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes to be committed: modified: egs++/ausgab_objects/egs_fluence_scoring/egs_fluence_scoring.h
- Added virtual methods setRussianRoulette and splitTopParticleIsotropically needed by the radiative splitting object. Changes to be committed: modified: egs++/egs_application.h
- Added two new methods needed by the radiative splitting object and provided more information in comments. - Turn ON/OFF EGSnrc internal radiative splitting (UBS) void setRadiativeSplitting( const EGS_Float &nsplit ); - Turn ON/OFF EGSnrc internal Russian Roultette + UBS void setRussianRoulette( const EGS_Float &iSwitchRR ); - Split particle uniformly in 4Pi void splitTopParticleIsotropically( const EGS_Float &fsplit ); Changes to be committed: modified: egs++/egs_advanced_application.h
- Added two new methods needed by the radiative splitting object and provided more information in comments. - Turn ON/OFF EGSnrc internal radiative splitting (UBS) void setRadiativeSplitting( const EGS_Float &nsplit ); - Turn ON/OFF EGSnrc internal Russian Roultette + UBS void setRussianRoulette( const EGS_Float &iSwitchRR ); - Split particle uniformly in 4Pi void splitTopParticleIsotropically( const EGS_Float &fsplit ); Changes to be committed: modified: egs++/egs_advanced_application.cpp
Initial radiative splitting naively just turned ON EGSnrc internal
flag nbr_split to split brems and annihilation events uniformly.
However no charged particle RR was played after pair production (i_play_RR)
nor were secondary photons, produced by charged particles surviving RR after
bremsstrahlung, split.
--------------------
Radiative splitting:
--------------------
now turned ON before a bremsstrahlung event for a primary or a fat charged
particle. It is turned OFF after the brems event to avoid higher order
splitting. Fluorescent fat photons, generated by fat charged particles
(survived RR) are also split.
NOTE: Not done for annihilation yet! Coming up!
This time RR is turned ON using EGSnrc internal flag i_play_RR so that RR is
played after pair events. RR can be turned OFF by entering a negative splitting number.
NOTE2: Brems events play RR intrinsically hence it can't be turned OFF.
Setting i_plpay_RR affects pair production ONLY.
Changes to be committed:
modified: egs++/ausgab_objects/egs_radiative_splitting/egs_radiative_splitting.cpp
modified: egs++/ausgab_objects/egs_radiative_splitting/egs_radiative_splitting.h
- Split annihilation in flight and at rest events for primary and fat positrons.
ftessier
force-pushed
the
fix_radiative_splitting_ao
branch
from
9d9cc41
to
4214601
Compare
rtownson
reviewed
Aug 3, 2023
|
|
||
| /* A fat particle's weight is larger than a thin particle's max weight */ | ||
| bool is_phat = (app->top_p.wt - wthin) > epsilon; | ||
| bool is_primary = app->top_p.latch == 0 ? true : false; |
There was a problem hiding this comment.
Is this compatible with a phase-space from BEAMnrc where the latch is already set? E.g. it's a primary particle but the latch is non-zero due to one of the bits being set by passage.
There was a problem hiding this comment.
I think it's fine to merge this is regardless, all it will lead to is less splitting in the cases where the latch has already been set.
But it might make sense to adjust:
if the latch is 0, it's primary; if it's 1, it's secondary; if bits 24-28 are 0, it's primary
ftessier
approved these changes
Aug 8, 2023
|
@blakewalters @mainegra this pull request is in conflict with #974 (add dbs to radiative splitting). Since the latter is still a draft, I suggest that we merge and then resolve conflicts in the |
|
I agree, @ftessier, let's get this merged in before worrying about DBS splitting, which shouldn't be affected by this change in any case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial radiative splitting implementation naively just turned ON EGSnrc internal flag
nbr_splitto split brems and annihilation events uniformly. However no charged particle RR was played after pair production (i_play_RR) nor were secondary photons, produced by charged particles surviving RR after bremsstrahlung, split.This PR fixes issue #1001
Implement radiative splitting + RR
Now turned ON before a radiative event for a primary or a fat charged particle.
Turned OFF after the event to avoid higher order splitting. Fluorescent fat photons,
generated by fat charged particles (survived RR) are also split.
RR is turned ON using EGSnrc internal flag
i_play_RRso that RR is played after pair events.RR can be turned OFF by entering a negative splitting number.
NOTE2: Brems events play RR intrinsically hence it can't be turned OFF.
Setting
i_play_RRaffects pair production ONLY.Other minor changes:
egs_dose_scoring.cppremoved the statement printing media names during dose output to the screen for dose to medium calculations. I have re-added the line.egs_dose_scoring.cppchanged the header formatting when outputting media doses which misaligned it.