Integrity#match bugfix and other optimizations #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @H4ad |
wraithgar
force-pushed
the
gar/common-match
branch
from
0063869
to
9ce806b
Compare
wraithgar
commented
Apr 11, 2023
| @@ -512,7 +563,7 @@ function createIntegrity (opts) { | |||
| } | |||
| } | |||
|
|
|||
| const NODE_HASHES = new Set(crypto.getHashes()) | |||
There was a problem hiding this comment.
Sets are slower to instantiate and only faster on lookups when we get into the thousands of entries. On my machine this has 52 entries.
wraithgar
force-pushed
the
gar/common-match
branch
from
9ce806b
to
8adaf9b
Compare
wraithgar
changed the title
wraithgar
changed the title
nlf
approved these changes
Apr 11, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #41
Built off of #76
Fixed up test coverage for that PR also