fix: properly handle missing algorithm type #48
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing a bug that happen in npm cli when installing a library.
in Line 272 the result of parse can be null if integrity is null. Then in line 273 other is null so it breaks as below:
Here parse can return null if sri is not defined or null.
Here
const algo = other.pickAlgoritm(opts)
this where it breaks whenother = null
.So we need to check whether other = null or not .
so a solution could be
OR
Reference
https://github.com/npm/cli/issues/5496
https://github.com/npm/cli/issues/3374